Diego Guidi

Results 96 comments of Diego Guidi

can you please explain a bit better your test and how to reproduce this?

please add a unit test (or a console app) with test data, so we can check.

maybe it's worth also to add the TryGet methods, just to have a consistent API? something like `public virtual bool TryGetZ(int index, out double value) { /* TBD*/ return true;...

Maybe you can find some suggestions here: https://github.com/NetTopologySuite/NetTopologySuite/pull/580

I just added some "formal" comments about the code, I don't know so much about the algorithm but I think you can add few unit test methods to show how...

> This looks fantastic and fingers crossed it works well @euangordon can you suggest some more unit tests?

~~not sure about how the unit tests in the XUniRunner are now failing, I see the same problem in my dev machine~~ ok now I see, probably it's the [same...

I see the same code in [jts codebase](https://github.com/locationtech/jts/blob/master/modules/core/src/main/java/org/locationtech/jts/simplify/DouglasPeuckerSimplifier.java#L209) so probably it should be fixed in JTS code too

I'd like to have a "core api" that is considered as standard (if used by EF.Core) and that GeoAPI extends. Not sure it's a viable option in short times.