Diego Guidi

Results 96 comments of Diego Guidi

makes sense to me, but probably we should also remove "VeDEx" references in the comments, that is a reference to a product I was working on probably 15 years ago!

Yep, absolutely

can you post a complete unit test or at least a complete unit of code that we can use to build a unit test using chinese characters? Thanks

ok I see that probably there's some problem [here](https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/develop/src/NetTopologySuite.IO.ShapeFile/Dbase/DbaseFileHeader.cs#L310) in L310 ``` // NOTE: only this _encoding.GetString method is available in Silverlight string name = DbaseEncodingUtility.Latin1.GetString(buffer, 0, buffer.Length); ``` but...

@FObermaier just take a look also here, please :)

@FObermaier @airbreather how about [this fix](https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/issues/39#issuecomment-722960208)? i can easily push this change if there is any objection

@axmand please can you provide at least some test data so I can build a valid test for this issue?

please check if last commit fix the issue, as expected

please post the complete code you're testing, from this I don't see why the line highlighted can throw a "ArgumentNullException" actually. No similar "throws" in the [source code](https://github.com/NetTopologySuite/NetTopologySuite.IO.ShapeFile/blob/develop/src/NetTopologySuite.IO.ShapeFile/ShapefileDataWriter.cs) I suspect...

this code works in .net, I made small changes ``` string path; string C_postal = "C_postal"; string Type_bat = "Type_bat"; string X_coord = "X_coord"; string Y_coord = "Y_coord"; //create geometry...