Cyrille C.

Results 65 comments of Cyrille C.

### Identify the root cause The root issue is that we are not checking if the URL finishes by a `.php` in the query add the URL to the preload....

> @CrochetFeve0251 Is this one ready to be reviewed again? @piotrbak it is

@Agathemed from what I saw in the code we need to add new cases for the licence, am I right? Just want to confirm before grooming.

@piotrbak look like the API doesn't provides us the information if an user is grand-fathered.

## Reproduce the problem The issue is easily reproducible. ## Identify the root cause The root issue is due to the fact the preload has been guarded against query strings....

### Scope a solution We could create add a filter in the loop changing [rows to in-progress](https://github.com/wp-media/wp-rocket/blob/cdf8f7bd07a2566b800d13f0981bf5babfd5b63f/inc/Engine/Preload/Controller/PreloadUrl.php#L178) that returns `true` by default so it will guard from passing that row...

## Scope a solution To prevent unnecessary requests we can create a lock system on the preload that would prevent locked rows from being loaded. For that we will need:...

### Identify the root cause The issue comes from the configuration of the msql server that are a maximum size of key inferior to what we expected. ### Scope a...

@engahmeds3ed is this PR still actual with the fact you removed the custom queue for preload?

### Scope a solution In the `is_already_cached` method from `PreloadUrl` : - Check if the option `cache_webp` is enabled. - If it is not the case keep the original process....