wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Update texts and banners for users with an expired license

Open Agathemed opened this issue 2 years ago • 4 comments

The messages for users with an expired license need to be updated:

  • to inform users about the optimize CSS features that will/have disappear/ed
  • to display the correct renewal price

Conditions and messages are available here.

Agathemed avatar Sep 06 '22 15:09 Agathemed

@Agathemed from what I saw in the code we need to add new cases for the licence, am I right?

Just want to confirm before grooming.

CrochetFeve0251 avatar Sep 07 '22 08:09 CrochetFeve0251

I believe the only case that is not in place yet is the "not grand-fathered user" scenario.

Agathemed avatar Sep 07 '22 08:09 Agathemed

@piotrbak look like the API doesn't provides us the information if an user is grand-fathered.

CrochetFeve0251 avatar Sep 07 '22 10:09 CrochetFeve0251

Scope a solution ✅

We need to update all the banners to update the part related to the price + discount that is going to be offered.

In Engine\License\Renewal:

  • Update display_renewal_soon_banner() method to check for grandfathered and change the message returned
  • Update display_renewal_expired_banner() method to check for grandfathered and change the message returned
  • Update the renewal views to display the new message from the variable
  • Update the related tests

Estimate the effort ✅

Effort [S]

remyperona avatar Sep 13 '22 13:09 remyperona