wp-rocket icon indicating copy to clipboard operation
wp-rocket copied to clipboard

Fixed a problem where Action Scheduler CRONs were remaining after the plugin was uninstall

Open CrochetFeve0251 opened this issue 2 years ago • 2 comments

Description

Remove Action Scheduler CRON when disabling the plugin by adding wp_clear_scheduled_hook on CRONs used to make AS queue run.

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [ ] Manually

Checklist:

Please delete the options that are not relevant.

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

CrochetFeve0251 avatar Aug 22 '22 14:08 CrochetFeve0251

  • Works fine when deactivating the plugin
  • As per discussion with the team, better to remove action_scheduler_run_queue cron when disabling related option

Mai-Saad avatar Aug 30 '22 15:08 Mai-Saad

@engahmeds3ed is this PR still actual with the fact you removed the custom queue for preload?

CrochetFeve0251 avatar Sep 06 '22 09:09 CrochetFeve0251