Thomas Brillard

Results 3 comments of Thomas Brillard

Agree for the signing API. Currently all wallets implements a `is_valid_signature` that returns true or false. It is on the [Account interface](https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/openzeppelin/account/IAccount.cairo) so I guess it could be on the...

> Hm that is weird, since we've been using the contract with it for awhile now. I wonder why might have changed? Could be worth escalating to the starkware team...

The reason is that `executeOnPlugin` is used to call any method on a plugin and those methods manages the caller check. You can see this In [StarkSigner](https://github.com/argentlabs/starknet-plugin-account/blob/main/contracts/plugins/signer/StarkSigner.cairo#L32) and [SessionKey](https://github.com/argentlabs/starknet-plugin-account/blob/main/contracts/plugins/SessionKey.cairo#L145). This...