walletconnect-docs icon indicating copy to clipboard operation
walletconnect-docs copied to clipboard

Initial Starknet specification

Open AlexBHarley opened this issue 2 years ago • 2 comments

What's this?

We (Steakwallet) want to allow users to connect to applications on Starknet via WalletConnect. This specification PR is the first step of many to make this a reality.

Reference links

Notes

  • I did not define a specification for starknet_addDeployTransaction because I believe wallets should be responsible for deploying contract wallets
  • We need an API for signing messages. I believe something like EIP-1271 should do the trick. Happy for someone from the Starknet team to provide guidance here
  • Decide on if we want a starknet_addInvokeTransaction method (omitting the signature field) for total parity that the wallet would simply sign and broadcast
  • starknet_declareTransaction not needed because it's related to contract deployment

Next steps

  • [ ] starknet_addInvokeTransaction is about to change (mid August) so we need to update this specification
  • [ ] Proof of concept in https://react-wallet.walletconnect.com and https://react-app.walletconnect.com/
  • [ ] Implementation in get-starknet-wallet library
  • [ ] Implementation in Steakwallet

AlexBHarley avatar Jun 24 '22 10:06 AlexBHarley

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
walletconnect-docs ✅ Ready (Inspect) Visit Preview Jun 24, 2022 at 10:54AM (UTC)

vercel[bot] avatar Jun 24 '22 10:06 vercel[bot]

Agree for the signing API. Currently all wallets implements a is_valid_signature that returns true or false. It is on the Account interface so I guess it could be on the API too.

Did you create a post on chaman to discuss about it? https://community.starknet.io/

CremaFR avatar Aug 16 '22 11:08 CremaFR

@AlexBHarley a year late - but it looks like we've added docs for Starknet: https://docs.walletconnect.com/2.0/advanced/rpc-reference/starknet-rpc

Is this PR good to close?

finessevanes avatar Jun 15 '23 21:06 finessevanes

Closed as RPC specs moved to WalletConnect/walletconnect-specs

pedrouid avatar Aug 14 '23 13:08 pedrouid