Cove Marquis-Bortoli

icon company @OpenZeppelin icon location Montreal icon location Full stack Ethereum Developer at @OpenZeppelin

Results 15 comments of Cove Marquis-Bortoli

Typscript implementation

I submitted a pull request :) https://github.com/scoutforpets/objection-password/pull/35

Typscript implementation

Hello, Any news on the PR ?

Create index.d.ts

Hello, any update on this ? :)

Highlight differences when changing features

Hey @kilnhast thanks for tackling the issue 🦾 Do you which to submit a merge request with your changes and collect feedback?

Highlight differences when changing features

Noted @kilnhast thanks for your investment, feel free to give this one or an other one go whenever 🌻

Feat/59 add natspec descriptions

Hey @mrscottyrose thanks for your MR ✨ Some considerations, when adding NatSpec we qwould probably want to align both content and formatting with what is found on the contract library...

Feat/59 add natspec descriptions

Thanks for making changes, please revert any type / number of arguments changes from the MR. In it's current state it does not build the package properly.

Feat/59 add natspec descriptions

@ernestognw could you validate/correct the comment's content?

Feat/59 add natspec descriptions

It seem that [this comment](https://github.com/OpenZeppelin/contracts-wizard/pull/549/files#r2100434775) has not been addressed? (seem like the specialised comment is deleted instead of overriding the general comment)

Feat/59 add natspec descriptions

Thanks for making the code changes 🦾 you will also need to [update the tests](https://github.com/OpenZeppelin/contracts-wizard/blob/master/CONTRIBUTING.md?plain=1#L33) as the contract got modified (with the added natspecs)