contracts-wizard icon indicating copy to clipboard operation
contracts-wizard copied to clipboard

Highlight differences when changing features

Open ericglau opened this issue 2 years ago • 6 comments

When adding or removing a selected feature, it may not be obvious what parts of the resulting code has changed. This is especially the case for Cairo because there is a lot of code that requires scrolling to view.

Enhance the UI so that differences are visibly highlighted when changing a feature.

For example, if the user starts with: Screen Shot 2023-01-12 at 4 56 55 PM then enables Mintable like the below: Screen Shot 2023-01-12 at 4 57 48 PM , this should cause the following sections to be highlighted:

import "@openzeppelin/contracts/access/Ownable.sol";

and

    function mint(address to, uint256 amount) public onlyOwner {
        _mint(to, amount);
    }

ericglau avatar Jan 12 '23 22:01 ericglau

Hey @ericglau ! can I get assigned to this issue?

kilnhast avatar Mar 26 '25 09:03 kilnhast

@kilnhast Thanks, feel free to contribute a PR

ericglau avatar Mar 26 '25 13:03 ericglau

Hi @kilnhast thanks for looking into this issue! We were thinking that it would be a nice motion interaction highlighting the differences if we'd animate the typing and removal of the code eg. https://cngu.github.io/vue-typer/?ref=madewithvuejs.com

Let me know if I can help in any way!

makiopen avatar Apr 14 '25 15:04 makiopen

Hey @kilnhast thanks for tackling the issue 🦾 Do you which to submit a merge request with your changes and collect feedback?

CoveMB avatar May 27 '25 15:05 CoveMB

Hi @CoveMB I've tried to solve it locally, but was unable to do it. As, I've been unsuccessfull in solving this, I think someone else should have a go at it. I don't want to hold this up for others. Thanks for being patient with me.

kilnhast avatar Jun 04 '25 08:06 kilnhast

Noted @kilnhast thanks for your investment, feel free to give this one or an other one go whenever 🌻

CoveMB avatar Jun 05 '25 23:06 CoveMB