CoreyHendrey comments

Results 20 comments of


                                            CoreyHendrey

Class Design

It's good to talk about though. Thinking about it more, it'd be better as a separate class entirely. We can then have things like friction (for sliding), velocity, gravity etc...

Class Design

Either way sounds fine. I’m just wondering how their movement will be different to the player though. I think my way may be a bit to convoluted. I was thinking...

Initial Project Discussion

I’m down. I work as a software engineer, but was previously employed as a graphic designer and illustrator. :)

Explain the code

I think it's just the holiday season :) It should pick back up soon.

Where to add Player instance in order to get instance of Player everywhere in the code

Already posted in the Pull Request, but to reiterate, I think this is a good idea too. Maybe we could have a seperate class to keep the adding functions in?...

Where to add Player instance in order to get instance of Player everywhere in the code

Sounds good, though I think "checkEnenmyCollisionWithPlayer( )" would be inside each enemy, rather than a global check, wouldn't it?

Where to add Player instance in order to get instance of Player everywhere in the code

Agreed

To Be Done

Proposed a change the animation system, let me know what you guys think. :)

To Be Done

Depends. If Ashish accepts my PR it’ll probably be in CharacterEntity.

Process input amounts are confusing when process can't run

Is this still a problem? I've been combing through the code for a while, and cannot seem to find anywhere that the current value is switched to the theoretical maximum....