Consti10

Results 169 comments of Consti10

A cuple of updates: 1) I found the reason for the client side crash - this one is a simple fix, the all_params callback takes a reference but this reference...

Sure, I'd love to talk to the author though, these changes might have implications one cannot see immediately. get_all_params() is now working again, but obviosly only returns parameters that do...

I've been working on mavlink_parameters for the last couple of days. My goal has been to reduce the amount of duplicated code,without reducing the public functionalities (which are thought out...

Oh dang, no, I did not know such a task is already underway - I totally agree though, splitting them into 2 is a really good idea.

Having a quick glance at it, one of the steps we both did is to extrakt ParamValue out ;) nice to see we are on the same page then.

And looking into your pull request, merging the 2 branches directly probably won't work, but especially since recv/ server are now split I think it would be easy for me...

One more thing I'd like to put out for discussion: Should the server-side make sure that parameter's types are immutable ? For example, when the client sends a [PARAM_SET](https://mavlink.io/en/messages/common.html#PARAM_SET) message,...

> And looking into your pull request, merging the 2 branches directly probably won't work, but especially since recv/ server are now split I think it would be easy for...

> > Do you have any local changes in regard to parameters or is this pull request still up to date ? > > No, that's all pushed. > >...

@julianoes I am mostly done with the param providing part (mavlink_parameter_receiver.cc / .h ) https://github.com/OpenHD/MAVSDK/blob/b3d9651391d888d949274095baa1f6ee5e7a4115/src/mavsdk/core/mavlink_parameter_receiver.h There are 2 TODO's left - 1) what to do if the value to set...