Victorien Elvinger

Results 323 comments of Victorien Elvinger

Hi @kaioduarte! I am sorry, I completely missed the fact that we already [noPrototypeBuiltins](have https://biomejs.dev/linter/rules/no-prototype-builtins/) which has some overlap with the rule you are implementing. ESLint has both [no-prototype-builtins](https://eslint.org/docs/latest/rules/no-prototype-builtins) and...

> Should I add prefer-object-has-own to the rule's sources array? Yes. This will avoid thinking that the rule was not covered.

LGTM Blocking the merging until we decide we no longer ship patch version for Biome 1.9. > I haven't done the read-only part yet, I only incorporated the changes from...

> I envision to fix it by using conflict-free replicated data types (CRDT) because the root cause is code actions that mutating some places can cause other code actions that...

> I use tsc --noEmit && biome check . in my package.json. Can I drop tsc? What will I miss if I drop tsc? Biome doesn't perform type checking and...

This looks like a legitimate, but niche case. If this doesn't complicate too much the rule, we could consider ignoring use of `void` in type parameter constraints. However, the list...

Let me think about that a bit more. I have several idea to sort out.

`includes` is very flat by nature. It is not well suited for merging. I see several approaches to "fix" the current issue: 1. Overriding. If a user set `.includes`, then...