Ives van Hoorne

icon indicating a website link https://twitter.com/CompuIves icon indicating an email [email protected]

icon company @codesandbox icon location Amsterdam, The Netherlands icon location Developer, traveler, tech enthusiast, working on codesandbox.io.

Results 179 comments of Ives van Hoorne

Tackling performance issues when searching on the same line multiple times

Hey! Firstly I want to say that I'm super grateful for all the work that you've done on `onigasm`, it has been super helpful for me while implementing `vscode-textmate`. I...

MMDS: Make header parsing case-insensitive

@luminitavoicu Saw that one test failed, I created a commit now which fixes that test!

MMDS: Make header parsing case-insensitive

I've updated the PR again to fix the tests, now there should be 0 change in behaviour and error logging.

MMDS: Make header parsing case-insensitive

Ah, there was still a test that verified an error message that I've changed and I hadn't signed all commits. Apologies for failing the tests each time, now it _should_...

MMDS: Make header parsing case-insensitive

Updated PR! 👍

MMDS: Make header parsing case-insensitive

Squashed and signed! 👍

Allow directly writing snapshots on top of existing files

> I think there's value in both use-cases, and the proposed changes in this PR seem to support both of them Yep, that's right. This would allow both for creating...

Allow directly writing snapshots on top of existing files

It seems like the tests are failing on test coverage, should I change a value here?

Allow directly writing snapshots on top of existing files

Rebased the PR, but I'm not sure what the code coverage is now with the changes that came from the rebase. Should I wait for a test run?

Allow directly writing snapshots on top of existing files

Added integration test as well!