Ives van Hoorne

Results 179 comments of Ives van Hoorne

Addressed the feedback, squashed the commits, signed it and updated coverage! I think the tests should now pass, though I did see other perf tests fail, so that's something we...

I'm on vacation right now but I have time next week! Just to be sure, does the package.json actually get updated? Does it have the new property in the generated...

> I'm sorry to trouble you, but did you have some time to look into this? I feel this can be something trivial, yet we'd appreciate your support. No worries!...

Ah I completely missed this notification, apologies for the late reply! I think this is a bug in our system, because it seems like while the template is set to...

Updated it! There's still one issue with the node version, but you can change the `sandbox.config.json` to set the node version to a later version.

I believe you're right @d3viant0ne, that's also how the conversation lead to this idea. Would love to help with this.

Hey! Sorry for the late reply, I believe this issue has now been fixed. It was related to how we converted es modules - they were not mutable and this...

> It seems this introduced a new issue. That error seems to be related to a circular dependency, there are two versions of `vega-dataflow`, one that `vega` needs (which is...

Good one! This should certainly be possible, the main question is how to determine that it's actually the same sandbox. I'm thinking of something like this: 1. (when sandbox is...

> I think there shouldnt be any magic here, just create something like .codesanbox.json with the sandbox's id and we are good to go. It has also the benefit of...