David

Results 526 comments of David

> That's the same as what I said about isTouchDevice. FocusManager and CoverBrowser don't deal in isKindle (nor should they) Yes but clearly something is being lost somewhere as it...

Note: https://github.com/koreader/koreader/blob/e94550a26165dd94875ae31a62bddea0125caa71/frontend/ui/widget/spinwidget.lua#L68 https://github.com/koreader/koreader/blob/e94550a26165dd94875ae31a62bddea0125caa71/frontend/ui/widget/numberpickerwidget.lua#L92

technically this is not necessarily limited to NT but in practice it would be, so could we get an NT tag, please.

```diff diff --git a/frontend/ui/widget/doublespinwidget.lua b/frontend/ui/widget/doublespinwidget.lua index 86b5a1d2e173..0057f457b813 100644 --- a/frontend/ui/widget/doublespinwidget.lua +++ b/frontend/ui/widget/doublespinwidget.lua @@ -68,6 +68,10 @@ function DoubleSpinWidget:init() end if Device:hasKeys() then self.key_events.Close = { { Device.input.group.Back } } +...

> to the top of `addToMainMenu`, then you will have `fc.display_mode_type` that is false for classic mode, or "list" or "mosaic". > You can use it to shorten all checks....

> * `Hide book covers` and `Replace book title with file name` do not stick : when you change mode, they are reset > * This is caused by the...

> (1) I am not sure that our file browser is a "library". (Collections are closer to "library" or "bookshelf") "Items" are changed to "books", but they can be (1)...

> > again, any other ideas? I was actually quite proud of that one. > > > > The obvious alternative to just `settings` is `file browser settings`. I don't...

okay, back here. I have been thinking about this, how to solve the issues and so forth. > I think you could still easily get Hide book covers to stick...

> You could store the individual state of hide_cover/use_filename in an internal variable, no need to save it, it would be remembered only for the current menu session. When the...