David

Results 526 comments of David

essentially, I can add the long-press, as all the heavy lifting is already done, but I can't do the grid bit

> > but I can't do the grid bit > > Unless I misundertood what you're expecting, I think I did it for you in the patch above ("Quick try:")....

> It works, it's just not very clear. > > It's also possible that you slightly typod this particular change, then it wouldn't do anything: > > ```diff > -...

Am I supposed to add/change/remove anything else besides this? > ```diff > --- a/plugins/coverbrowser.koplugin/mosaicmenu.lua > +++ b/plugins/coverbrowser.koplugin/mosaicmenu.lua > @@ -930,6 +930,7 @@ function MosaicMenu:_updateItemsBuildUI() > -- Build our grid >...

> It works with the caveat that you can't go right, so to go right you have to go left. But that's orthogonal. It's easier to merge 3 separate PRs:...

step 2, disables completely the dPad on K4. including the middle `Press` key. I can't test on K3 as I still need to install KUAL and KOReader there, but I...

could you test if the emulator works if you set it to NT and not has keyboard? I don't get it, but it just won't work on K4

Well as i said, the dPad does not do anything at all, normally you should get an underline to indicate what you would be selecting, it doesn't appear, also you...

> So if you press down, say, 3 times and then press enter or "hold" you don't see any result? (As distinct from whether you see any selection visually.) Absolutely...

update: I just tried these changes on the kindle keyboard and the same thing happens. dPad does not work. could you guys try to pretend to be `isKindle()` and non...