David

Results 526 comments of David

what is this (poke ball, I guess) one? ![Screenshot 2024-04-10 at 15 17 30](https://github.com/koreader/koreader/assets/97603719/2ccd5846-e455-4b9d-be07-b62b92f1aa8a) I sometimes see it on ePubs but have no idea what it means. gotta catch 'em...

that works! should I PR this or will you?

I found the [guilty] offender here #8608. 😂

> The former isn't supposed to show on non-touch devices. Maybe something like this would do the trick? > > ```diff > diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua > index e80998717..abba38f1f 100644...

I tried to get it to work without `tableDeepCopy` and every approach I try fails... I am sure it will be something silly and obvious once it is solved but...

> You just have `menu_items.selection_text = menu_items.long_press`, right? that was the very first thing I tried, and it didn't work for some reason. But now it does, weird.

> In KOReader you mark something as finished, is there a reason for why we use "finished" instead of the more obvious and wildly used term "read"?

> Because the word "read" is much harder to disambiguate in these kinds of situations. `Read` could also mean `Open` as opposed to "Readed". not suggesting anything here but, but...

I am sorry to disappoint but book title, was already in use: https://github.com/koreader/koreader/blob/caea0e8fb2e07c27670137e3ebbb4945f34b5ce0/frontend/apps/reader/modules/readerfooter.lua#L984 I just embraced it.

So it is faster to render the whole book than to make that bookmark list, that's something. I already think "full search" takes a bit too long when you look...