Colin Eberhardt

Results 221 comments of Colin Eberhardt

Ok, could be a useful feature, but would be relatively complex, requiring extra API call to determine the files ‘touched’ by each commit within a PR. I also wonder about...

Hi @BPScott thanks for getting in touch! I do wish I'd seen Probot earlier, it does look like it makes a number of things I've implemented manually a lot easier...

One solution to this is to just push the problem onto the (cla-bot) user. Rather than the cla-bot config file containing a whitelist of GitHub logins, it could contain a...

Hi @maoo you're absolutely right, that is the same. As an alternative, I was thinking of allowing the contributors array to contain a combination of GitHub IDs or email addresses.

That’s a good point - although as this used a serverless architecture, there isn’t a container of server to ping for status check. One other thing I could do is...

Hi @electrum rather than sending emails, I've modified the bot so that it reports errors in the JSON configuration file via the GitHub build status. You can see it in...

@maoo can you please provide some guidance around how license validation should be run as part of the CI process? I executed the commands at linked in CONTRIB-57, but see...

Thanks @maoo that worked. The demo project includes quite a few additional licenses, for reference these are as follows: ``` MIT Apache-2.0 BSD-2-Clause BSD-3-Clause ISC ``` Do these need to...

@maoo are you happy for us to move this repo into the FINOS org now?

@maoo all of the issues raised are very similar in nature, relating to jQuery vulnerabilities. Here's a brief analysis of just one of them ... Regarding: /openfin-react-hooks/demo/node_modules/vm-browserify/example/run/index.html This relates to...