Colin Eberhardt

Results 173 comments of Colin Eberhardt

>> Assembly Script to generated the function that polyfills does feel like overkill > I think it will be more maintainable For complex polyfills I'd agree, but in this case...

Yeah, I’d go runtime for simplicity. It’s a pretty simple transform and transforms aren’t really that performance critical

Thanks for the detailed report. As you've no doubt worked out this issue is due to the presence of a [custom name section](https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#name-section) within your wasm binary. The binary encoded...

> wasm-parser: as we saw before, both (index and identifier) are important informations. I would suggest to simply add both to your AST. (i'm 👍 on this). Just to clarify,...

With the changes for #257 function AST nodes can now either include the signature directly, or indirectly as a type references. Currently the interpreter will throw a runtime exception if...

Good point - I like how it is documented here: https://github.com/sunfishcode/wasm-reference-manual/blob/master/WebAssembly.md#constant In this case, `i32.const 0`, the zero is an immediate, rather than an argument. It is not part of...

Basically, I think args should be used for anything that can be written in a nested form, i.e. ``` (f64.const 0) (f64.abs) ``` can be nested as ... ``` (f64.abs...

> Currently we store them as instructions in the function body which is closer to text format Well ... it does depend on how you format the text file. This...

On a related note, I am wondering about the WAT parser within this project. Doesn't something already exist via the JavaScript build of BinaryEn? https://github.com/AssemblyScript/binaryen.js/