cla-bot icon indicating copy to clipboard operation
cla-bot copied to clipboard

Cannot verify commits from authors that do not have GitHub accounts

Open ColinEberhardt opened this issue 7 years ago • 2 comments

The code looks for commit.author.login, however this is the payload we see for these authors:

 "commit": {
                "author": {
                    "name": "---,
                    "email": "---",
                    "date": "2018-04-26T00:19:43Z"
                },
                "committer": {
                    "name": "---",
                    "email": "---",
                    "date": "2018-04-26T00:19:43Z"
                },
                "message": "Demoved duplicate quote",
                "tree": {
                    ...
                },

ColinEberhardt avatar May 31 '18 14:05 ColinEberhardt

Looks very similar to https://github.com/ColinEberhardt/cla-bot/issues/74 , right? Would be great to generate a list of {{ unknownUsers }} that can be mentioned in the .clabot message, containing the list of commit.author.name that cannot be resolved by GitHub APIs. wdyt?

maoo avatar May 31 '18 15:05 maoo

Hi @maoo you're absolutely right, that is the same.

As an alternative, I was thinking of allowing the contributors array to contain a combination of GitHub IDs or email addresses.

ColinEberhardt avatar Jun 05 '18 07:06 ColinEberhardt