Kevin Chung
Kevin Chung
I think a better idea would be to discuss in #1711 why you think blank flags should be blocked.
I generally don't engage too much on this repo since a lot of the code was re-written by @Kronuz from what I originally wrote and I don't generally use it...
If you figure out an appropriate solution here a PR would be welcome!
The problem it seems is that some Vagrant VMs don't have the feature enabled by default. By running the following commands you should be able to turn it on. ```...
Also there are problems if the VM is unable to be connected to because it is missing a network adapter.
It seems like vmrun is not properly linking the current directory to the vmx. Once it gets set, it doesn't change. Looks like we might need to rewrite the vmx...
I am not sure, those commands should only work if VMWare Tools is installed. There aren't a lot of things besides start and stop that will work if Tools aren't...
This PR is super duper big. I know you just closed some other PRs but it's much easier to process changes broken down by feature instead of all together.
@mkinney you will need to break this up. Tests and bash completions could be separate PRs. As well as could tests.
https://www.thedroidsonroids.com/blog/splitting-pull-request You should probably cherry pick the commits that you want into the separate feature branches that they represent.