Kevin Chung

Results 334 comments of Kevin Chung

Also just my two cents, I think rating relative to performance of the teams would be ideal. Voting would introduce too much gaming of the system. Say top ten teams...

This was an addition by a PR when someone wanted to add the `solved_by_me` field to `/api/v1/challenges`. I agreed with the addition but I do see that it could be...

I could consider removing it in a 4.0 release. But I feel like it shouldn't be a very complex query? If you could try to optimize the query on your...

I don't think this would be possible with how CTFd works. Especially if you consider things like case sensitivity and regex flags. If you propose a way that it could...

That wouldn't really achieve much because you would just store a hash value which you could have done using the static flag.

I suppose this is a worthwhile idea but tbh transactional emails (like email confirmations) should be delivered as fast as possible. This kind of issue sounds like it's really more...

I thought we had already done this but this is a good change!

Ah I see this was handled specifically in the challenges endpoint: https://github.com/CTFd/CTFd/blob/4793d95338935686ef005c24ebb6606e1be7403b/CTFd/challenges.py#L30-L31 It should be fine to put this into the decorator but I'm wondering why it didn't already work...

I see that this behavior actually only takes place if the user directly browses to /challenges sometime after creating an account. A user that freshly registers is prompted to go...