Kevin Chung

Results 334 comments of Kevin Chung

Yeah it should be added. It's just been a little difficult to work with Swagger. I have perhaps some ideas about migrating to a better API codebase like FastAPI but...

This issue appears to only show up if you try to re-use your own email address.

I thought this was harder than it looked but I think you could get away with: ```diff diff --git a/CTFd/api/v1/users.py b/CTFd/api/v1/users.py index deace1c1..0d6836ca 100644 --- a/CTFd/api/v1/users.py +++ b/CTFd/api/v1/users.py @@ -132,7...

Looks simple but I think it kind of makes the code more complicated than it needs to be. I'd like to restructure these models entirely honestly.

I'm kind of lazy on this and I don't think this scenario comes up very often. The fix isn't too hard but I think it puts in a little too...

I like this idea but I'm confused a bit on how you use it? Are you trying to create new different types of challenge pages within the same theme or...

For example what I'm thinking is if you add the following code to `ThemeLoader.get_source()`: ```python if template.startswith("core/"): template = template[5:] template = "/".join(["core", "templates", template]) return super(ThemeLoader, self).get_source(environment, template) ```...

Yeah I agree! I also think `{% extends core/challenges.html %}` is a good feature to have. The blocks themselves are useful but I think using them in that template overriding...

I'm playing around with this idea and it's definitely useful but I think those are kinda specific scenarios that might be better suited by some other ideas I have. I'm...