CohenArthur

Results 260 comments of CohenArthur

some notes from discussing this with jakub: ``` │18:20:52 jakub │ cohenarthur1: depends on what you want to test; if it is just test whether "do I need to link...

@SIGMazer thanks for the PR :D the changelog in your second commit message needs to appear in the first one too - each commit should contain such a changelog entry....

@SIGMazer do you need help fixing the failing CI steps?

@SIGMazer the best thing would be to resolve the conflict outside of github, with the tool you use for git (git command line or gitgui, or maybe gitkraken etc). you...

yes, as @P-E-P said this is specifically for the `dg-output` directive - so the script is a good start, it just needs to be a little more precise

oh damn, so there were only two testcases remaining? interesting! thanks for fixing that @badumbatish

now I need to find someone willing to run our testsuite on windows :)

Ah, that's nice thanks @bjorn3! I like that more. But if we want to compile liballoc 1.49 we'll sadly still have to deal with it

> Yes, that's going in the right direction. 👍 > > At least partially, this again (like #2942 "Check for cargo when building rust language") needs to go into the...

> Only `crab1` should then be linked against these libraries, not all GCC things generally. right, so add `-ldl -lpthread` to something like `CRAB1_LIBS` instead? I think we have `RUST_LIBS`...