CohenArthur

Results 260 comments of CohenArthur

> Are you referring `expansion` to these lines in `rust-session-manager.cc`? > > if (last_step == CompileOptions::CompileStep::Expansion) > return; > > auto name_resolution_ctx = Resolver2_0::NameResolutionContext (); > // expansion pipeline stage...

another testcase, which is more important in the context of `format_args!()`: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=c29c2bfb8f0df802c939cdb8aecaf717 ```rust struct Formatter; struct Result; trait FakeDisplay { fn fmt(&self, f: &mut Formatter) -> Result; } impl FakeDisplay...

oh, that's really sad... any chance there's another make variable you haven't thought about which is just the linker binary and not the full invocation? it seems this is the...

a very simple fix which is probably not correct is the following: ```c++ if (scrutinee_kind == TyTy::TypeKind::ADT) { // this will need to change but for now the first pass...

@nobel-sh it removes the ICE, but I whipped it up in 5 minutes without really thinking or testing it out so that's why I'm saying it might not be correct...

@sahilyeole you just need to rebase this on the latest master and we can merge it :)

@sahilyeole the CI is failing because the API changed a little bit for the code you're using :) if you adapt it we can merge it

Will send that patch upstream for review before merging it, in the hopes it makes it to 14.2

note that this was done exclusively because the build was breaking in our GCC 4.8 CI - other contributors on IRC have mentioned the existence of flags/autoconf functions to check...