gccrs Do not link -ldl and -lpthread unconditionally

Apr 12 '24 14:04 CohenArthur

Yes, that's going in the right direction. :+1:

At least partially, this again (like #2942 "Check for cargo when building rust language") needs to go into the top-level configure, in order to be able to gracefully disable GCC/Rust for --enable-languages=all configurations.

Apr 12 '24 14:04 tschwinge

Yes, that's going in the right direction. 👍

At least partially, this again (like #2942 "Check for cargo when building rust language") needs to go into the top-level configure, in order to be able to gracefully disable GCC/Rust for --enable-languages=all configurations.

yeah, I saw that Jakub had mentioned this but it does seem a bit too late to make such a change, no? Jakub had also mentioned erroring out, which is what I chose to do here

Apr 12 '24 15:04 CohenArthur

It's late no matter whether in the top-level configure, or gcc/configure. ;-|

Apr 12 '24 15:04 tschwinge

Gracefully disable for implicit "rust" in --enable-languages=all, error out for explicit --enable-languages=rust.

Apr 12 '24 15:04 tschwinge

Only crab1 should then be linked against these libraries, not all GCC things generally.

Apr 12 '24 15:04 tschwinge

Only crab1 should then be linked against these libraries, not all GCC things generally.

right, so add -ldl -lpthread to something like CRAB1_LIBS instead? I think we have RUST_LIBS for this already, I'll check.

Gracefully disable for implicit "rust" in --enable-languages=all, error out for explicit --enable-languages=rust.

so you're forcing me to do more autotools work, do you like seeing me suffer or something? :P will work on this next

Apr 12 '24 15:04 CohenArthur

The implicit vs. explicit thing should be really easy ;-) in the top-level configure: just like how #2942 "Check for cargo when building rust language" does this, and similarly for GCC/D if gdc or GCC/Ada if gnat is not available in a suitable version.

Apr 12 '24 16:04 tschwinge

@tschwinge I've made the required changes and pushed them :) tested locally and it seems to work fine on a system where glibc < 2.34. tested with --enable-languages=all and --enable-languages=rust

Apr 16 '24 13:04 CohenArthur

Should we merge this ? Has it already been merged upstream ? It requires a rebase anyway.

May 21 '24 11:05 P-E-P

I'm going to merge this PR because it has been merged upstream, sadly it introduce a regression because I'm too stupid for autotools and shell scripting in general, so I'll open a follow-up PR shortly

Jun 12 '24 08:06 CohenArthur

turns out that the bug/issue does not actually prevent the build from completing, it's just noisy but the build completes. I'll still push the fix ASAP

Jun 13 '24 15:06 CohenArthur