Vladimir Smirnov

Results 294 comments of Vladimir Smirnov

Problem with any tags support on go-carbon side, that there should be some sort of compatibility with the way how it's done in graphite-web as people would expect it to...

About the old effort on tags, I've actually have a sort-of-working version of go-carbon that was based on your old PR (and outcome of the hackaton from Early 2018) and...

> So yes, the strong point about this new implementation is that it changed neither filename nor metric path, because when tags are updated or removed, That sounds like a...

As usual, it's always about tradeoffs. Either you need to keep track on what changed when (I think this is what you are talking about now?), or live without history...

Well, this is timeout only for querying `/_internal/capabilities` handler to determine if backend supports carbonapi_v3_pb. In both graphite-clickhouse and go-carbon those are just returning static json back, which should be...

> Well or maybe the other place using the same error message, not 100% sure to be honest, but I didn't manage to workaround it with any of the existing...

I'm not sure that it's necessary thing to do, maybe as a low-prio thing. It'll mostly move complexity from broadcast group to client group. But I agree that it will...

Actually it might be not that easy. As apparently previous attempt of optimising that path lead to a very nasty bug that dramatically degraded performance with high concurrency. Issue there...

Eventually yes, as currently carbonapi is rather far away from feature parity with graphite-web (I think currently we have less than 90% of all functions that are there in 1.1,...

Basically @deniszh is right. Actual database support is not a big deal, as we have aliasByPostgres in there will be also way to do alias by redis in near future....