carbonapi icon indicating copy to clipboard operation
carbonapi copied to clipboard

[FR] Events support

Open jdblack opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. We have a moderately large graphite stack (2.1 mil metrics/sec) that we are currently serving with graphite-web because of it's event support.

Is event support on the roadmap? Is database support the main blocking issue?

jdblack avatar Mar 23 '21 21:03 jdblack

Hi @jdblack ,

As far as I know events never was in the scope of this project. But what stopping you from switching rendering to carbonapi while keeping events on old setup? If it will not serve rendering it can be significantly reduced.

deniszh avatar Mar 23 '21 21:03 deniszh

Basically @deniszh is right.

Actual database support is not a big deal, as we have aliasByPostgres in there will be also way to do alias by redis in near future.

It's something that is nice to have eventually, but it would require some effort to understand how it's implemented in graphite-web and to make it compatible. Plus I've never seen anyone who had a use case for them. It's always harder to implement something that you don't know how to use :)

But I'm willing to accept a PR that would implement graphite-compatible event function.

At this moment maybe it would be better to proxy this function with graphiteWeb function (it's possible to configure it to be a transparent proxy, however since I've implemented it I haven't heard a lot of feedback about it, so either it works perfectly or no one uses it enough to file bugs)

Civil avatar Mar 23 '21 21:03 Civil

My five cents: we use grafana annotations in the company

Felixoid avatar Mar 23 '21 21:03 Felixoid

Grafana annotations is an option, indeed - but they dropped support for Graphite event compatible protocol long time ago. But migration should be quite straightforward IMO

On Tue, 23 Mar 2021 at 22:59, Mikhail f. Shiryaev @.***> wrote:

My five cents: we use grafana annotations in the company

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/go-graphite/carbonapi/issues/588#issuecomment-805294435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJLTVSREI6TH7QZYUZMXHTTFEFM3ANCNFSM4ZV72S2Q .

deniszh avatar Mar 23 '21 23:03 deniszh