ChristopherHX

Results 120 issues of ChristopherHX

breaking: docker container are removed after job exit In github-act-runner I directly instantiate the RunContext, but I also want to make use of autoremove due to randomized job container name.

size/M

Weird inputs and env are both evaluated in the env context. This change delays the evaluation of INPUT_ env vars and makes the step env available. This feels like a...

size/M

No public interface has been changed. TODO - [x] Add tests for bugs of the old docker_run impl. - [x] Add tests for GITHUB_OUTPUT / GITHUB_STATE

size/L

### Bug report info ```plain text N/A ``` ### Command used with act ```sh ./act -P self-hosted=-self-hosted -W /home/christopher/github-actions/host_environment/pkg/runner/testdata/failing-pre-step-logging/push.yml | grep STATE_ ``` ### Describe issue The state is of...

kind/bug

Some people try to use something for step level if on job level. Make it clear that this is not supposed to work. Fixes #1474

size/M

Reason actions/runner doesn't use /usr/bin/tail in the entrypoint, it uses tail without /usr/bin/ prefix. Fixes https://github.com/nektos/act/issues/1449

size/XS

I'm potentially breaking non standard act specfic workflows With this change are all file commands in a single place again. Closes #1384 Closes #1421

size/L

Needed by github-act-runner to compile for dragonfly, plan9, etc. I moved the types into container_types.go without changing them. The docker package is not compatible with dragonfly, while the rest of...

size/L

~_Should I preserve the public ImageExistsLocally signature and make a private helper function?_~, reverted the new return value. This uses docker inspect and remove docker list. You cannot have multiple...

size/M

This change now also unifies RUNNER_OS with runner.os, I suggest to do the same thing for the github context. _This is a breaking change for github-act-runner, but we should align...

size/M