refactor: GITHUB_ENV command / remove env.PATH

[ChristopherHX]

I'm potentially breaking non standard act specfic workflows

With this change are all file commands in a single place again.

Closes #1384 Closes #1421

[github-actions[bot]]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	12		0	0.04s
✅ REPOSITORY	gitleaks	yes		no	2.41s
✅ REPOSITORY	git_diff	yes		no	0.0s
✅ REPOSITORY	secretlint	yes		no	0.98s

See detailed report in MegaLinter reports Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov[bot]]

Codecov Report

Merging #1503 (3237a13) into master (4989f44) will increase coverage by 0.68%. The diff coverage is 75.44%.

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
+ Coverage   61.22%   61.91%   +0.68%     
==========================================
  Files          46       46              
  Lines        7141     7246     +105     
==========================================
+ Hits         4372     4486     +114     
+ Misses       2462     2457       -5     
+ Partials      307      303       -4     

Impacted Files	Coverage Δ
pkg/container/docker_cli.go	82.23% <ø> (ø)
pkg/container/docker_logger.go	52.08% <ø> (ø)
pkg/container/docker_pull.go	33.33% <ø> (ø)
pkg/container/docker_run.go	13.58% <ø> (ø)
pkg/container/docker_volume.go	0.00% <ø> (ø)
pkg/container/docker_images.go	27.02% <29.41%> (-4.13%)	:arrow_down:
pkg/model/github_context.go	61.06% <32.00%> (-19.40%)	:arrow_down:
pkg/container/docker_auth.go	51.35% <56.25%> (+3.73%)	:arrow_up:
pkg/runner/runner.go	86.45% <66.66%> (-2.05%)	:arrow_down:
pkg/runner/step.go	83.33% <75.00%> (+0.36%)	:arrow_up:
... and 19 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[mergify[bot]]

@ChristopherHX this pull request is now in conflict 😩

[ChristopherHX]

@catthehacker provided some details about the act images I didn't know, so this PR should be blocked for now to not break users.

This PR removes also reading other envs than PATH from /etc/environment, so this break everything for these images.

[ChristopherHX]

I opened a PR to the act docker images repo https://github.com/catthehacker/docker_images/pull/83 to resolve the issues caused by this PR.

I'm not shure how to enshure that docker images are semi uptodate, because this is a breaking change for the docker_images repo.

~~Oh no recent changes to branch protection rules, made the update branch button disappear, GitHub settings are fixed~~

[catthehacker]

I'm not shure how to enshure that docker images are semi uptodate, because this is a breaking change for the docker_images repo.

What do you mean?

[ChristopherHX]

I mean act doesn't pull images by default. Some may end up creating an issue about missing node in PATH.

[catthehacker]

Change so it pulls by default 😛

or add feature that fetches latest meta about used image and warn user when image is outdated/doesn't match

[ChristopherHX]

I added more tests and fixed an issue, which leaked the step env of the composite actions.

You can now define env variables with the same name as a env var in the step env as new global variables, tests has been added.

I hope this PR doesn't cause new issues and I think this is ready now.

[mergify[bot]]

@ChristopherHX this pull request has failed checks 🛠

No, only coverage upload failed with a weird error.