act icon indicating copy to clipboard operation
act copied to clipboard

docs: clarifying skipping steps / jobs

Open ChristopherHX opened this issue 2 years ago • 4 comments

Some people try to use something for step level if on job level. Make it clear that this is not supposed to work.

Fixes #1474

ChristopherHX avatar Nov 28 '22 17:11 ChristopherHX

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 1 0 0.01s
✅ MARKDOWN markdownlint 1 0 0.28s
✅ REPOSITORY gitleaks yes no 2.7s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.89s

See errors details in artifact MegaLinter reports on CI Job page Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

github-actions[bot] avatar Nov 28 '22 17:11 github-actions[bot]

Codecov Report

Merging #1480 (9e1ea46) into master (4f8da0a) will increase coverage by 2.89%. The diff coverage is 66.59%.

@@            Coverage Diff             @@
##           master    #1480      +/-   ##
==========================================
+ Coverage   57.50%   60.40%   +2.89%     
==========================================
  Files          32       44      +12     
  Lines        4594     7000    +2406     
==========================================
+ Hits         2642     4228    +1586     
- Misses       1729     2465     +736     
- Partials      223      307      +84     
Impacted Files Coverage Δ
pkg/common/file.go 0.00% <0.00%> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/host_environment.go 0.00% <0.00%> (ø)
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 12.82% <11.53%> (+7.27%) :arrow_up:
pkg/model/workflow.go 45.65% <23.58%> (-5.26%) :arrow_down:
...ontainer/linux_container_environment_extensions.go 24.32% <24.32%> (ø)
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
... and 37 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Nov 28 '22 17:11 codecov[bot]

is mergify suppose to kick in here and merge .. ?

20k-ultra avatar Nov 30 '22 21:11 20k-ultra

Multiple approvals are required

KnisterPeter avatar Nov 30 '22 21:11 KnisterPeter