Yanjun Zhang

Results 18 comments of Yanjun Zhang

Yes I added more detailed documentations for WSL too!

@sbryngelson I fixed 2D axisymmetric and added detailed documentation for it. For the 3D cylindrical coordinates, I wasn't able to get it working (its previous implementation was actually for 2D...

Sorry I didn't read the thread properly. No, I didn't manage to get it working. Was also wondering where the documentation is

> Excellent! Glad to have new features. I still need to do code review... Thanks for helping us review the code! Just to let you know, I still need to...

Thanks for helping to test it! Looks like the dependency issue is specific to my system... I'll look for the cause

> Having a look... in the meantime I found this > ``` > Failed test tests/16A922E4: 1D -> weno_order=3 -> mapped_weno=T after 3 attempt(s). > ``` > which follows from...

> It's unclear why WENO7 is incompatible with grid stretching? We use the stretching feature often. It should be compatible, but I haven't done it. Will need to find a...

Also, the build error is not specific to my machine. The same error appears on both Bridges2 and Delta for CPU compilation when I: 1. build 2. add a comment...

Here's the error message on Bridges2 (same on Delta): ``` [yzhang28@bridges2-login013 MFC]$ [yzhang28@bridges2-login013 MFC]$ ./mfc.sh build -j 4 mfc: OK > (venv) Entered the Python 3.8.6 virtual environment (>= 3.8)....

> FYI we've seen some weird issues like this before. I don't think it is MFC specific, though it's hard to know for sure. I haven't seen it in weno,...