Chris Thrasher

CSFML is a big enough codebase that we'd benefit significantly from clang-format and clang-tidy enforcing a higher degree of code quality and consistency.

Use .hpp extension for private C++ headers

1

All of the headers in src/ are actually C++ code since they use C++ headers and C++ symbols. We should use a .hpp extension for such files instead of .h.

`ImPlot::PlotLineG` forces data to be mutable

2

https://github.com/epezent/implot/blob/cc5e1daa5c7f2335a9460ae79c829011dc5cef2d/implot.h#L856 The signature for `ImPlot::PlotLineG` uses a `void*` which implies that the data it is reading is mutable. This means you cannot use something like a `const std::vector` and call...

Start using `ament_target_dependencies` privacy specifiers

1

Now that `ament_target_dependencies` lets you specify `PUBLIC`, `PRIVATE`, or `INTERFACE` we should ensure that we're also specifying one of the three.

Replace empty classes with namespaces

2

**Describe the solution you'd like** Convert classes like [`trajectory_processing::RuckigSmoothing`](https://github.com/ros-planning/moveit2/blob/main/moveit_core/trajectory_processing/include/moveit/trajectory_processing/ruckig_traj_smoothing.h#L45) to namespaces. Because they contain no non-static data members, there is no reason these need to be classes. All the private...

Depend on 3rd party ament packages via `target_link_libraries` where possible

1

Many modern ROS packages export a single CMake target that encodes everything required to use it. For those packages we are better off using `target_link_libraries` to link to that target....

**Describe the bug** I use ``` defaults: run: shell: bash ``` at the top of my shell scripts to ensure all steps of all jobs use bash. One such step...

Use `cmake` crate to build SFML via CMake

1

https://crates.io/crates/cmake There is a CMake crate that can be used to build CMake-based libraries. This would allow for removing all CSFML source code from the repo and will make future...

Remove incomplete installation support

2

Installing applications with runtime assets like fonts and shared libraries is not trivial. This single install command gives users the impression that they can install their programs but falls short...

Clarify usage instructions

4

**Specify what directory to run CMake commands from** I never mentioned that you have to run those CMake commands from the same directory as the repo. It's fair to assume...