Chris Thrasher

Results 360 comments of Chris Thrasher

I like the motivation behind install.sh keeping everything as simple as possible for new users but I think information about how to install dependencies is best suited for the README....

@kimci86 > The private constructor Time(Int64 microseconds) could be removed as it is used only in microseconds function which could use the new constructor instead. Good point. I'll remove that....

I squashed some commits too since I thought 4 or 5 commits was excessive for a change of this scale.

What do we think about a [user-defined conversion function](https://en.cppreference.com/w/cpp/language/cast_operator)? This would do the exact opposite of the new constructor template allowing for implicit (yet typesafe) conversions back to durations. ```cpp...

I went ahead and added the implicit conversion to `std::chrono::duration`.

No changes. Just keeping up with `master`.

Rebased on master and fixed new compilation error introduced by a57640c2c89042d7ecc2c5f87712b553c8e14612

> but introduce very hard-to-read chrono shenanigans To be fair, this is idiomatic `` code. However verbose the API is, anyone familiar with C++11 time utilities will know what is...

I changed how we're printing standard types such that we never have to open up `namespace std` since I'm not 100% sure that's legal.

> Now it only needs a small comment to explain why we use StringMaker for stringification. Done