Keeyou

Results 25 comments of Keeyou

> Thanks for the PR. > > In general when sending a PR to fix an issue it helps to explain what the problem is that's being fixed, and a...

> > Reviewed 8 of 8 files at r1, all commit messages. > > _[Reviewable](https://reviewable.io/reviews/ycm-core/ycmd/1624)_ status: 0 of 2 LGTMs obtained (waiting on @Chilledheart) > > _[ycmd/completers/cpp/flags.py, line 373 at...

> Thanks for the pull request. I did leave two small comments, but the change to `flags.py` looks fine. > > > Reviewed 6 of 8 files at r1, 2...

> > Reviewed 1 of 1 files at r3, all commit messages. > > _[Reviewable](https://reviewable.io/reviews/ycm-core/ycmd/1624)_ status: 0 of 2 LGTMs obtained (waiting on @puremourning) > > _[ycmd/tests/clang/diagnostics_test.py, line 399 at...

Then I noticed the fact that `RemoveUnusedFlags` whose caller is `PrepareFlagsForClang` which is only called when it comes to a compiler database it is not true for the unittest where...

> > Reviewed 1 of 2 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages. > > _[Reviewable](https://reviewable.io/reviews/ycm-core/ycmd/1624)_ status: 0 of...

> Thanks. Can we update the tests? > > > _[Reviewable](https://reviewable.io/reviews/ycm-core/ycmd/1634#-:-MzxXEFx7CFb6XXi2BBm:b-kvakxq)_ status: 0 of 2 LGTMs obtained Nice idea! One small problem remains, `--drive-mode=cl` mode is supported under macOS/Linux which...

Interesting, I am using Asio with C++17 (maybe filesystem library in C++20 soon) and never bother to use a post libraries. I also use standalone http parser for Http 1.1...

Updated: I found several bugs inside the release ipa (iOS) Please use the latest (1.5.14) [ipa file][new-ios] instead of the old one. TesfFlight invitation url: https://testflight.apple.com/join/6AkiEq09 hi all, i managed...

> hi all, i managed to make some naiveproxy-compatible GUI clients both on [iOS](https://github.com/Chilledheart/yass/releases/download/1.5.9/yass-ios-release-arm64-1.5.9.ipa) and [Android](https://github.com/Chilledheart/yass/releases/download/1.5.9/yass-android-release-arm64-1.5.9.apk) (ipa and apk files url). While I tested it on iOS 17 and Android...