ycmd
ycmd copied to clipboard
cpp: support -imsvc
Codecov Report
Merging #1634 (29f5294) into master (9ce9158) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #1634 +/- ##
=======================================
Coverage 96.08% 96.08%
=======================================
Files 90 90
Lines 8044 8044
Branches 164 164
=======================================
Hits 7729 7729
Misses 263 263
Partials 52 52
Thanks. Can we update the tests?
Reviewable status: 0 of 2 LGTMs obtained
Nice idea!
One small problem remains, --drive-mode=cl
mode is supported under macOS/Linux which means you can cross-compile Windows programs under macOS/Linux in a MSVC-like way. However, in the unittests the previous testcases are marked as @WindowsOnly
. Should we remove this restriction?
ycmd/tests/clang/flags_test.py:L1066
@WindowsOnly
def test_RemoveUnusedFlags_RemoveStrayFilenames_CLDriver( self ):
my recollection is that it's all quite fiddly in this area. if the tests pass reliably on linux/macOS, then yeah sure, but ideally minimise complexity in this area. Thanks!
thanks!
Thanks for sending a PR!
Thanks for sending a PR!
Thanks for sending a PR!
Thanks for sending a PR!