ycmd icon indicating copy to clipboard operation
ycmd copied to clipboard

cpp: support -imsvc

Open Chilledheart opened this issue 2 years ago • 6 comments

the option is supported for the MSVC-like frontend, just like -isystem for GNU-like frontend.


This change is Reviewable

Chilledheart avatar Apr 06 '22 03:04 Chilledheart

Codecov Report

Merging #1634 (29f5294) into master (9ce9158) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1634   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files          90       90           
  Lines        8044     8044           
  Branches      164      164           
=======================================
  Hits         7729     7729           
  Misses        263      263           
  Partials       52       52           

codecov[bot] avatar Apr 06 '22 04:04 codecov[bot]

Thanks. Can we update the tests?

Reviewable status: 0 of 2 LGTMs obtained

Nice idea! One small problem remains, --drive-mode=cl mode is supported under macOS/Linux which means you can cross-compile Windows programs under macOS/Linux in a MSVC-like way. However, in the unittests the previous testcases are marked as @WindowsOnly. Should we remove this restriction?

ycmd/tests/clang/flags_test.py:L1066

  @WindowsOnly
  def test_RemoveUnusedFlags_RemoveStrayFilenames_CLDriver( self ):

Chilledheart avatar Apr 07 '22 08:04 Chilledheart

my recollection is that it's all quite fiddly in this area. if the tests pass reliably on linux/macOS, then yeah sure, but ideally minimise complexity in this area. Thanks!

puremourning avatar Apr 07 '22 10:04 puremourning

thanks!

puremourning avatar Aug 13 '22 16:08 puremourning

Thanks for sending a PR!

mergify[bot] avatar Aug 13 '22 16:08 mergify[bot]

Thanks for sending a PR!

mergify[bot] avatar Aug 13 '22 23:08 mergify[bot]

Thanks for sending a PR!

mergify[bot] avatar Aug 14 '22 08:08 mergify[bot]

Thanks for sending a PR!

mergify[bot] avatar Aug 14 '22 10:08 mergify[bot]