Chi Cheng

Results 55 comments of Chi Cheng

I maintain a scientific software package (currently closed source) which uses the numba AOT compile in pycc so I guess this deprecation will affect us at some point. I understand...

I've tested the idea out and I think this is an improvement. Here I use the long DLPOLY water trajectory and for the new scheme I use 1/2 trajectory correlated...

Also the documentation for the 1st order velocity is not the same as what is done in the code above. The code and/or documentation needs to be corrected. ![image](https://github.com/ISISNeutronMuon/MDANSE/assets/14276033/ea9d5034-9b42-4a06-a3fe-001b5aa1fe02)

Also the current implementation of angular correlation does not follow what is stated in the documentation. The current implementation and/or code will need to be changed. ![image](https://github.com/ISISNeutronMuon/MDANSE/assets/14276033/b236d686-961b-479e-b7f8-47f9105c6e61)

Bonding types could be determined with rdkit see #350.

I guess the weight scheme should be like this then ![image](https://github.com/ISISNeutronMuon/MDANSE/assets/14276033/67480d1a-255c-401c-b6b8-9a1d63c546c4) where $a$ is the atom, $i$ is the index of an atom $a$ and $n_i$ is whether the atom...

@conda-forge/help-python-c all test pass. This PR is ready for review.

@conda-forge/help-python-c any ideas when this will be reviewed? Are some issues with the PR?

Are there other jobs with the same issue when a trajectory contains one atom? I'd imagine the static structure factor and dynamic coherent structure factor might also have a similar...