staged-recipes icon indicating copy to clipboard operation
staged-recipes copied to clipboard

add MDANSE and MDANSE_GUI

Open ChiCheng45 opened this issue 2 years ago • 6 comments

Checklist

  • [x] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x] License file is packaged (see here for an example).
  • [x] Source is from official source.
  • [x] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [x] If static libraries are linked in, the license of the static library is packaged.
  • [x] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x] Build number is 0.
  • [x] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [x] When in trouble, please check our knowledge base documentation before pinging a team.

ChiCheng45 avatar Mar 28 '24 16:03 ChiCheng45

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/MDANSE) and found some lint.

Here's what I've got...

For recipes/MDANSE:

  • The home item is expected in the about section.
  • The following maintainers have not yet confirmed that they are willing to be listed here: MBartkowiakSTFC. Please ask them to comment on this PR if they are.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/MDANSE:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

Hello, I'm a maintainer.

MBartkowiakSTFC avatar Mar 28 '24 16:03 MBartkowiakSTFC

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/MDANSE) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/MDANSE, recipes/MDANSE_GUI) and found it was in an excellent condition.

@conda-forge/help-python-c all test pass. This PR is ready for review.

ChiCheng45 avatar Mar 28 '24 21:03 ChiCheng45

@conda-forge/help-python-c any ideas when this will be reviewed? Are some issues with the PR?

ChiCheng45 avatar Jun 17 '24 13:06 ChiCheng45

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

stale[bot] avatar Apr 16 '25 05:04 stale[bot]