Charles

Results 33 comments of Charles
trafficstars

So you ask people to see #4786 in this PR, and closed #4786 to ask people to see this PR? If I understand correctly, you still prefer this implementation, right?

> Drive-by comment: thanks for making this! Scary to see that TypeScript metaprogramming goes this deep (path generation). > > Hoping to help test this. > > * Would it...

> Some thoughts after converting a PoC: > > * Using `type Store = typeof store` and `InjectionKey` makes more sense now. Sadly that doesn't have a nice fallback for...

> Thanks for the fixes! > > > createStore() now accepts the virtual parameter stricterTypes in its options: > > I needed to move the `stricterTypes` overload first (just like...

It will be awesome to have this feature! It fits mikro's design well and benefits GraphQL apps greatly.

> I think `undefined` would be more correct `JSON.stringify()` does not support `undefined`, they will be directly ignored

`FrameworkModule` detects databases by tokens, and the debugger replies on the detected databases, which is the reason of why the issue disappears when providing databases using other tokens. ```ts if...

Types [will not be computed when its argument is another generic type argument](https://github.com/microsoft/TypeScript/issues/30480), thus we might have to use many type assertions in our code, which destroys the user experience:...

Hi did you possibly forget to install the build tools required by node-gyp? ``` 1255 error gyp ERR! find VS 1255 error gyp ERR! find VS msvs_version not set from...