Charles comments

Results 39 comments of


                                            Charles

docs: correct browserslist behavior docs

Hey @alan-agius4 I've signed the CLA, but I believe it can be more convenient to squash the commits on merge. The edits were made via GitHub Web.

feat(dialog): Ability to present MatDialog fullscreen

As the dialog component in Angualr Material Experimantal has adopted the implementation from MDC, where full-screen dialog is available, I believe it is super easy for the team to implement...

Detect iPad OS 13+ with cdk/platform

I believe this should be an essential feature of the platform package

[Bug] Route-level Environment Initializer Skipped During AppEngine Route Discovery

Addition: such environment initializers used to work with Angular v19.0. After upgrading to Angular v19.1, they are skipped.

[Bug] Route-level Environment Initializer Skipped During AppEngine Route Discovery

Hi @alan-agius4 thanks for the feedback. The workaround to https://github.com/angular/angular/issues/51532 is to use a route level environment initializer to get the injector instance, so that `loadChildren` can be wrapped to...

[Feature] Introduce Type-safe Token Providing

I see. I think it would still be nice to add `provide()`.

[Feature] Introduce Type-safe Token Providing

lol I didn't notice the number.

[Feature] Introduce Type-safe Token Providing

Do you expect me to create a PR? What am I supposed to do next?

[Feature] Introduce Type-safe Token Providing

I feel it more semantical correct to use `provideUseValue` or `provideFromValue`, since it is the "token" that you are providing. Besides, I think this syntax might result in not-that-good-looking code...