Chandra Pratap

Results 19 comments of Chandra Pratap

> For now we could just change that location to use `tal_strcat`. This would allow the fuzz target to actually work, so we can run it and see if we...

> HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI. Hey @madelinevibes, no this PR...

> great, thanks! can you please rebase before we review? Done!

The latest push triggers the `Assertion 'bitcoin_tx_check(tx)' failed.` bug when run on the corpus for some time even though it disables all the developer options...

> I looked into this. It seems that `state->localconf->dust_limit` is getting set to a really high value, which causes this problem. CLN normally sets this value to 546, so probably...

Hey @morehouse, I've fixed all of the crashes but the only thing that bugs me is that the latest target isn't able to make it past [this check](https://github.com/ElementsProject/lightning/blob/c1ad55c601a25a462ac15d51db03cf8dc68a370d/openingd/openingd.c#L1265). I believe...

> Yep, assertion failure confirmed here: I ran the target for quite some time but was unable to reproduce this failure. Do you mind sharing the crashing input?

The crash happens because the peer seems to create a `peer_error` message with `create_fuzz_msg()` here: ``` if (fromwire_u8(cursor, max) % 2 == 0) { struct sha256_double h; struct bitcoin_signature sig;...

> Rebased. The inter-daemon comms changed, so the corpora will have to be rebuilt I think? Hey @rustyrussell, I was trying to rebuild the corpus for this test but the...