Chandra Pratap

Hey @morehouse , running this test throws the following errors: - `common/amount.c:359:18: runtime error: -nan is outside the range of representable values of type 'unsigned long'` - `common/amount.c:345:23: runtime error:...

> In practice, all current usages of these functions in the codebase have positive values for `scale`, so the bug can never manifest in the existing codebase. Makes me wonder...

Hey @morehouse, As we discussed over email, I spent some time last week investigating the potential bug caused by an assertion failure in `amount_msat_sub_fee()` to determine whether it could be...

The test works without any breakage now and is ready to be merged.

The corpus for this test is now generated with the fix in #8306 applied, so that PR needs to be merged before this one can.

The test results in the following LeakSanitizer error when run on its corpus: ``` ==116428==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s) in 1 object(s) allocated from: #0...

> We might need to manually delete all elements from the gossmap at the end of each iteration. This makes the target a bit messier but _does_ seem to manage...

I was fixing some of the other issues with this target when it ran into yet another memory leak: ``` ==31969==ERROR: LeakSanitizer: detected memory leaks Direct leak of 40 byte(s)...

> Have you been able to run this fuzz target? I tried and hit a bunch of crashes immediately. > > Only reproduces when I use multiple workers, and seems...

> We can try to hack around the issue though. Maybe we could redefine `GOSSIP_STORE_FILENAME` to be some function call `get_gossip_store_filename()`, which then returns a thread-local temp file name. In...