lightning icon indicating copy to clipboard operation
lightning copied to clipboard

fuzz-tests: Make `fuzz-bolt12-offer-decode` roundrip

Open Chand-ra opened this issue 2 months ago • 4 comments

Changelog-None: Currently, the BOLT #12 offer parsing test only tests the offer decoding function. Add a test for the encoding function as well by making the test roundtrip.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • [x] The changelog has been updated in the relevant commit(s) according to the guidelines.
  • [x] Tests have been added or modified to reflect the changes.
  • [x] Documentation has been reviewed and updated as needed.
  • [x] Related issues have been listed and linked, including any that this PR closes.

Chand-ra avatar Oct 27 '25 15:10 Chand-ra

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI. I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

madelinevibes avatar Dec 08 '25 04:12 madelinevibes

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI.

Hey @madelinevibes, no this PR does not address any open issue.

It is an improvement to an existing fuzz test and is meant to better help in catching regressions in the future. So yes, I suppose it is 'just for CI'.

I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

Makes sense.

Chand-ra avatar Dec 08 '25 07:12 Chand-ra

HI @Chand-ra it seems this one got lost for 25.12, is there an open issue that this PR solves? or if just for CI.

Hey @madelinevibes, no this PR does not address any open issue.

It is an improvement to an existing fuzz test and is meant to better help in catching regressions in the future. So yes, I suppose it is 'just for CI'.

I have added it to the milestone for our release early 2025. It will need to be reviewed still!!

Makes sense.

great, thanks! can you please rebase before we review?

madelinevibes avatar Dec 08 '25 23:12 madelinevibes

great, thanks! can you please rebase before we review?

Done!

Chand-ra avatar Dec 09 '25 06:12 Chand-ra