Pierre Ossman (ThinLinc team)
Pierre Ossman (ThinLinc team)
Thank you! This looks like a good change. Just let me have a closer look and we can then merge it.
New commits, please. But not a new PR. You can force push things to this branch and it should update properly.
You don't need to sync things if you don't want to. We can usually handle that as we merge. :) That said, doing a merge is not the ideal way...
VNC by its very nature already assumes a decent availability of bandwidth, but I suppose in some cases audio could be the tipping point. Make sure it is a property,...
I manage to get things up an running on web-test-runner, but tests hang on failure because of this bug: https://github.com/modernweb-dev/web/issues/2772
Band-aid in 1b2fe3321bface82604f2c5034cbc2ad8396560a. Unknown how long until the next thing breaks.
The WebCodecs definitely looks like a better fit. No arguments there. But if WebCodecs isn't fully supported yet, the question is if it's possible to build a more complex solution...
That does sound very complex. I was hoping it was a smaller step, like having to frame the data better, or some extra steps to get the data out (like...
> I added a couple of basic tests for `H264Parser` and `H264Context`, but I intend to add more. I hope it's OK to export those. I don't see any other...
> VNC doesn't explicitly define color space anywhere. But given its nature, sRGB would be the base assumption. That is, assuming the data stream doesn't specify an explicit colour space....