Pierre Ossman (ThinLinc team)

Results 349 comments of Pierre Ossman (ThinLinc team)

Thanks. That doesn't scale terribly well. And we have 765 such assertions. Any workaround would need to be somewhere more central. :/

> Depending on for which Sinon Chai methods you want to implement the work around you can extend the plugin. Would this help you @CendioOssman ? Possibly. It is a...

Hmm.. Very odd that it didn't resolve the issue here for me in that case. @lucaelin, is this issue something you are aware of and working on?

This looks like a convention, rather than something fundamental to redis? That makes me cautious about adding it, as not everyone might follow that convention. Why can't users include this...

Ah, yes. The security aspect is a good point. You need to be able to keep that out of end user control. I quickly googled redis and namespaces, and it...

I'm afraid I'm not familiar with redis, so I don't know how much of a limitation not supporting it would be. We could skip it for now, as long as...

Thanks for your suggested fix! I'm a bit cautious about just picking an arbitrary limit, though. Perhaps it's better to move away from this brute force method and instead enumerate...

I assume you mean `os.closerange()`? It should have similar issues. Might be fast enough, since it's likely written in C instead. But might not. For the '/proc/self/fd' approach, it's not...

Did you also check the suggested patch above?

Thank you for your PR! Yes, those are optional. But might be overlooked by users, so there is some value to not forcing users to jump through extra hoops. What...