Cellan Hall
Cellan Hall
Hey! Would also love to work on this project. Count me in 😆
Hey @otaj, I am happy to work on the following to start as they are connected: - `pl_bolts.datamodules.sklearn_datamodule.SklearnDataModule` - `pl_bolts.datamodules.sklearn_datamodule.SklearnDataset` - `pl_bolts.datamodules.sklearn_datamodule.TensorDataset` - `pl_bolts.models.regression.linear_regression.cli_main` - `pl_bolts.models.regression.linear_regression.LinearRegression` - `pl_bolts.models.regression.logistic_regression.cli_main` - `pl_bolts.models.regression.logistic_regression.LogisticRegression`...
> Hi @Ce11an! I left couple comments. I know it looks like a lot, but I have to say, I really like the ideas in this PR and general style!...
Thank you @luca-medeiros @otaj for reviewing the PR 🥳 My actions from your comments are the following: - [ ] Remove the dependence of `x`/`data` and `y`/`target` - [x] Remove...
> Thank you @luca-medeiros @otaj for reviewing the PR 🥳 > > My actions from your comments are the following: > > * [ ] Remove the dependence of `x`/`data`...
Hi @otaj and @luca-medeiros I have done some thinking regarding a `BoltsDataset` and I believe I have a solution that fixes some of the issues: ``` from typing import Optional,...
Hi both, I am closing this PR and splitting it out into several different ones as the `SklearnDataModule` needs more refinement. I have made a PR for the `ArrayDataset` #872....
Has anyone attempted to write their own stubs for SageMaker? Looking for a solution until this issue is resolved. Thanks 🙏🏼
We are also using option 2. The `pre-commit` solution is a good idea, but I am looking for something cleaner. I am going to try using [stubgen](https://mypy.readthedocs.io/en/stable/stubgen.html) in the meantime....