Daryle Walker

Results 21 comments of Daryle Walker

In the Swift Forums discussion thread for this type, [I suggested](https://forums.swift.org/t/api-review-priorityqueue-apis/49932/34) adding an element search method. I put it in a pull request to the repo this pull request is...

> The `replaceMin` and `replaceMax` members look like good additions to me. BTW, do you have motivating example for adding these? It's not immediately obvious to me that these operations...

> Just want to add that the types `SortedSet` and `SortedDictionary` would also allow for **finally adding binary search** to Swift. That should probably be in the Algorithms library, so...

I used "scan" in the title because it's technically a term-of-art, so casuals reading the PR list would have more of an idea what's going on. The PR with `reductions`...

Don't `endsOfCommonPrefix(with:)` and `startssOfCommonSuffix(with:)` overlap with `diverges(from:)` and `converges(with:)` from #37 ?

This is now obsolete from my next attempt at [#184].

> something like .`adjacentPairs().map(...)` Where is "`adjacentPairs`" defined at?. It appears only as part of a comment (for permutations) in this project.

Is a "recursive mapped sequence" a term of art for a particular structure? I've never heard of it before, and the documentation so far assumes you pretty much already know....

You could probably generalize the `Collection.firstRange(of:)` method (and therefore `BidirectionalCollection.lastRange(of:)` too) with an equivalence predicate and/or letting the collections differ in `Element` type. The given predicate would be allowed to...

> 1. **Naming** > I wouldn’t have guessed this would be the behavior of a function named `copy`. This may be because I’ve programmed a lot more Objective-C than C++...