Carter Francis
Carter Francis
@pc494 I think I'm happy with it. The only thing I'd like to double check is that I correctly accounted for the Ewald sphere. I've never actually see a good...
I'll clean this up, maybe add some equations and then add this to the documentation. I feel like this is one of those things that people who have been in...
But there is also this case where the distance you want to measure is actually the cord of the sphere. Maybe it really doesn't matter. Maybe this is already accounted...
@pc494 Nothing about this is blocking and if we want to drop pyfai we can pretty easily do it now. I've been using this a bit but still need to...
@viljarjf This is a great addition and very welcome here! One thing to note is that markers in hyperspy are going to change with the 2.0.0 release (which should be...
@viljarjf If you want to get a head start on this you can always rebase this one #969. That should be all of the necessary changes to get this working...
> I redid it with hyperspy 2.0 now, it made the code a lot easier and faster. Having a IPF as navigation space makes a lot of sense, I will...
> > I think it would be a little better to have a get_orientation_map function in the PolarSignal class then we could > > have the get_orientation_map function return an...
@viljarjf What is the status on this? I can review it if you would like and we can add in the color navigator to a different PR?
@emichr This looks like a good bug fix. The failing tests are related to a change upstream in pyfai that I was unaware of, I'll submit a bug fix for...