Carter Francis
Carter Francis
I think we should be able to just make this a function of the `StrainMap` class and then add something that saves any rotation applied to the data from `StrainMap.rotate_strain_basis`...
> I would keep it simple and plot the vector basis on the strain maps themselves, as in for example: https://github.com/ericpre/gpa_demo/blob/main/GPA_defocus_serie.ipynb That seems like a good idea. It would be...
> Sorry to be boring but is this a pre or post `0.18.0` project? I just thought it would be nice for the paper :) right now the strain section...
> Couple of small little changes I think would make this a bit more resilient. @pc494 Sounds good! I might have to think about how we could change things in...
@pc494 this is probably good to review again
@viljarjf Have you tried setting `usetex =True`? Basically the `TextsColletion` will go through and predict the bounding box and then center based on that. I think I tried to test...
Just for reference the new method takes ~.3 msec to transform a 256x256 image into a polar image but around ~70 msec for a 2kx2k image. The radial method in...
> The main purpose of the polar transform utility functions is to map cartesian images and templates expressed in the cartesian coordinate system to the polar domain as efficiently as...
This is the function: https://github.com/pyxem/pyxem/blob/da7c8f6d730d8cbc3ebbd9c504b7186180ee6c7b/pyxem/utils/_azimuthal_utils.py#L28-L66 It's a bit weird because it is split into two parts. The first part is precomputing a bunch of stuff: https://github.com/pyxem/pyxem/blob/da7c8f6d730d8cbc3ebbd9c504b7186180ee6c7b/pyxem/utils/calibration_utils.py#L250-L266 edit: (There is also...
> It's difficult for me to figure out exactly what this is doing or how it works just from a quick read, so for me, as long as you can...