Carter Francis
Carter Francis
@emichr can you please rebase this PR on the `main` branch just to make sure all of the tests are passing?
> Hm, it still looks like the tests are failing @CSSFrancis. It seems the tests assumes the center passed to the function is in calibrated units, not in pixels. Perhaps...
@emichr any chance you can rebase this again and then we can get this merged assuming that the CI passes?
@emichr hopefully this helps and makes sense! @hakonanes any chance you can add me as a maintainer to pyxem. It would be nice to be able to direct edit pull...
> Agreed though I think a change of API (which I think is necessary) would make this redundant. Maybe this is something to think about > > Make a generator...
So I've been thinking about how to best do this. Because we already have a `PolarDiffraction2D` class I think it makes the most sense to: 1a. Convert a `Diffraction2D` signal...
Here is a little bit more detailed of a road map: - [x] New Calibration class #993 - [x] Increase Coverage #1000 - [x] Deprecate CalibrationGenerator #1000 - [ ]...
@nhagopian You have been using both packages a little bit interchangeably so any insight you have would be useful.
@pc494 Yes, I also think it would probably be better to have this as an tutorial rather than a new feature
@TimothyLambdenCambridge Great to talk to you a couple of weeks ago! I've been a little bit busy with this but it would be good to see about implementing some of...